Skip to content

Add select source to soundtouch#33490

Closed
boxcee wants to merge 4 commits intohome-assistant:devfrom
boxcee:add-select-source-to-soundtouch
Closed

Add select source to soundtouch#33490
boxcee wants to merge 4 commits intohome-assistant:devfrom
boxcee:add-select-source-to-soundtouch

Conversation

@boxcee
Copy link
Copy Markdown
Contributor

@boxcee boxcee commented Apr 1, 2020 •
edited
Loading

Proposed change

It is impossible to change the source of the SoundTouch at the moment. This PR should add the functionality to change source.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: soundtouch small-pr PRs with less than 30 lines. labels Apr 1, 2020
Moritz Schmitz von Hülst and others added 2 commits April 1, 2020 09:52
@boxcee
Copy link
Copy Markdown
Contributor Author

boxcee commented Apr 1, 2020

@da-anda care to take a look at this?

@da-anda
Copy link
Copy Markdown
Contributor

da-anda commented Apr 1, 2020 •
edited
Loading

@boxcee I think @MartinHjelmare is more qualified for this. I can do some testing if you like. Having a look at your code I just wondered where/how HA would get the list of selectable sources. You probably would need some form of enumeration for this since I'm not sure that all soundtouch devices support BT and AUX. libsoundtouch doesn't seem to provide this info from a quick look though

@da-anda
Copy link
Copy Markdown
Contributor

da-anda commented Apr 1, 2020

you also might want to have a look here CharlesBlonde/libsoundtouch#34 and here #31071

@springstan springstan changed the title add select source to soundtouch Add select source to soundtouch Apr 1, 2020
@boxcee
Copy link
Copy Markdown
Contributor Author

boxcee commented Apr 1, 2020

Ah, thanks. There is also #31669.

@homeassistant
Copy link
Copy Markdown
Contributor

homeassistant commented Apr 1, 2020

Hi @boxcee,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant deleted a comment from homeassistant Apr 1, 2020
@home-assistant home-assistant deleted a comment from homeassistant Apr 1, 2020
@jtommi
Copy link
Copy Markdown
Contributor

jtommi commented Apr 13, 2020

Hi @boxcee ,
I'm the one from #31669.
May I use some of your code to finish the feature ?
My merge request is slow because some tests are failing and I'm currently going through a book about Test driven development in Python to feel more comfortable with that stuff.
I'd also be very happy to work together on this feature.

@boxcee
Copy link
Copy Markdown
Contributor Author

boxcee commented Apr 13, 2020

@jtommi Most definitely. Will close this one then, okay?

@boxcee boxcee closed this Apr 13, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed integration: soundtouch small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@boxcee @da-anda @homeassistant @jtommi @MartinHjelmare